Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration of M-Elo #1

Merged
merged 14 commits into from
Aug 1, 2024
Merged

Integration of M-Elo #1

merged 14 commits into from
Aug 1, 2024

Conversation

Nimeggis
Copy link
Member

Checklist for reviewer

  • The code is easy to understand
  • The code follows
    the coding guidelines of
    this project
  • The code is tested or if not, the reason is documented or discussed
  • The added and existing tests reasonably cover the code change
  • The code has no breaking changes in the database schema or if so, the assignee is aware of it and
    will perform a database migration

PaulBredl
PaulBredl reviewed Jun 20, 2024
View reviewed changes
Copy link
Contributor

@PaulBredl PaulBredl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hab nur ne Anmerkung zu nem gelöschten Test.

src/test/java/de/unistuttgart/iste/gits/flashcard_service/api/TestAuthorization.java Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wurde der Test gelöscht, weil er nicht mehr durch lief? Wenn ja, würde ich stattdessen den eher einfach ausschalten mit der @Disabled annotation, statt den Code wegzuwerfen. Wenn der Test einfach nicht mehr nötig ist, dann passt es natürlich. (siehe auch https://junit.org/junit5/docs/5.2.0/api/org/junit/jupiter/api/Disabled.html)

PaulBredl
PaulBredl reviewed Jun 20, 2024
View reviewed changes
Copy link
Contributor

@PaulBredl PaulBredl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Einer der Tests failt noch

@myluki2000
Copy link
Contributor

Test still failing

@myluki2000 myluki2000 merged commit d5d5967 into main Aug 1, 2024
1 check failed
@myluki2000 myluki2000 deleted the integration-of-MElo branch August 1, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PaulBredl PaulBredl PaulBredl left review comments

@myluki2000 myluki2000 myluki2000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Nimeggis @myluki2000 @PaulBredl @TessaKeller